Add tests for error cases in did-resolver.spec.ts #561
Conversation
This commit adds new tests in did-resolver.spec.ts to cover some of the previously uncovered error-related branching paths. This commit contributes partly to issue decentralized-identity#136. Based on the output of `npm run test:node` before vs. after this commit, the `% Branch` is now increased by 9.66 percentage points, and the `% Stmt` and `% Lines` by 3.29 percentage points. Before: ``` did-resolver.ts | 87.91 | 78.57 | 66.66 | 87.91 ``` After: ``` did-resolver.ts | 91.2 | 88.23 | 66.66 | 91.2 | ```
shobitb
requested review from
mistermoe,
csuwildcat,
thehenrytsai and
diehuxx
as code owners
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
There was a problem hiding this comment.
@shobitb thanks for helping us increase CC! Could you opportunistically convert the Error used in DidResolver into DwnError and introduce new error codes? Search for DwnError and you'll find pattern used in code and tests.
Yes, most def. Let me take a look and will send an updated PR. |
This commit adds new tests in did-resolver.spec.ts to cover some of the previously uncovered error-related branching paths. This commit contributes partly to issue decentralized-identity#136. Based on the output of `npm run test:node` before vs. after this commit, the `% Branch` is now increased by 9.66 percentage points, and the `% Stmt` and `% Lines` by 3.29 percentage points. Before: ``` did-resolver.ts | 87.91 | 78.57 | 66.66 | 87.91 ``` After: ``` did-resolver.ts | 92.34 | 94.11 | 66.66 | 92.34 | ```
|
@thehenrytsai — I've added new error codes and used them in did-resolver, but also changed a few error handling branches in did.ts using the new codes. How does this look? Thanks! |
This commit adds new tests in did-resolver.spec.ts to cover some of the previously uncovered error-related branching paths. This commit contributes partly to issue decentralized-identity#136. Based on the output of `npm run test:node` before vs. after this commit, the `% Branch` is now increased by 9.66 percentage points, and the `% Stmt` and `% Lines` by 3.29 percentage points. Before: ``` did-resolver.ts | 87.91 | 78.57 | 66.66 | 87.91 ``` After: ``` did-resolver.ts | 92.34 | 94.11 | 66.66 | 92.34 | ```
Gotcha! I originally thought the codes were like HTTP codes, where a generic code could be used with different specific error messages. Added a new code for |
|
I don't have write access, so please merge when you can. Thanks a lot, @thehenrytsai! |
EbonyLouis
added
the
hacktoberfest-accepted
* main: Add codecov coverage job in `integrity-check.yml` (#542) Add support for compressed secp256k1 publicKey (#567) Add range filter support for dataSize (#568) Replace `handle<Xyz>` methods in `Dwn` class with overloaded `process… (#566) Add tests for error cases in did-resolver.spec.ts (#561) add browser tests to gh actions. (#541)
This commit adds new tests in did-resolver.spec.ts to cover some of the previously uncovered error-related branching paths.
This commit contributes partly to issue #136.
Based on the output of
npm run test:nodebefore vs. after this commit, the% Branchis now increased by 9.66 percentage points, and the% Stmtand% Linesby 3.29 percentage points.Before:
After: